Remove finetuning stage from test_example_scripts #2085
Conversation
Removed finetuning stage configuration from test script. Signed-off-by: Dipika Sikka <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the test suite by removing outdated finetuning configurations from example scripts. This change ensures that the tests accurately reflect the current capabilities of the system, specifically acknowledging that training is no longer a supported feature. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the 'finetuning' stage from the stages dictionary in the verify_2of4_w4a16_output test function. This change is consistent with the deprecation of training/finetuning functionality, ensuring that the test script no longer attempts to verify the output of a stage that is no longer executed. The change is correct and I have no further comments. As a follow-up, you might consider also removing the now-unused finetuning_stage from the corresponding recipe file examples/quantization_2of4_sparse_w4a16/2of4_w4a16_recipe.yaml to keep the configuration files clean.
Removed finetuning stage configuration from test script as training is no longer supported.